Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hooks): build local useBreakpointValue and useMediaQuery hooks #13695

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Aug 21, 2024

Description

Creates the useBreakpointValue and useMediaQuery hooks locally.

useBreakpointValue references the Chakra UI useBreakpointValue as is simplified.

useMediaQuery is an amalgamation of the hooks from usehooks-ts and from Chakra UI to account for an array of media queries.

This should be scrutinized in knowing how simple or complex this pair need to be for the project's purposes.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1d4ef15
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66dbb9099f4c5c0008e24631
😎 Deploy Preview https://deploy-preview-13695--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 7 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 87 (🔴 down 5 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review August 23, 2024 02:59
@pettinarip pettinarip mentioned this pull request Sep 5, 2024
3 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @TylerAPfledderer. Works perfectly in the current instances.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


const breakpointMap = {
// Essentially to query from no width if smaller than "sm"
base: "0px",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pettinarip pettinarip merged commit 816648c into ethereum:dev Sep 10, 2024
8 of 10 checks passed
@TylerAPfledderer TylerAPfledderer deleted the feat/local-use-breakpoint-value branch September 16, 2024 18:34
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants