Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add stablecoins quiz [Fixes #13649] #13704

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Feat: add stablecoins quiz [Fixes #13649] #13704

merged 11 commits into from
Oct 9, 2024

Conversation

Shiva-Sai-ssb
Copy link
Contributor

Description

As specified in the issue, I have added the quiz for stablecoins in this PR.

Related Issue

Closes #13649

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Aug 22, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a66c73d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670635ce7a3943000830b042
😎 Deploy Preview https://deploy-preview-13704--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 43 (🔴 down 10 from production)
Accessibility: 94 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 15 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shiva-Sai-ssb
Copy link
Contributor Author

Hey @konopkja,

I need some help with the quiz I'm trying to add. I successfully added the Stablecoins quiz to the quizzes page, and it's working perfectly there. However, when I added the quiz to the Stablecoins page using the StandaloneQuizWidget, it isn't displaying correctly. The quiz questions and options are showing up as in the attached image.

Screenshot (170)

Could you please suggest what's causing this issue and how I can fix it?
Thanks in advance!

@konopkja
Copy link
Contributor

konopkja commented Sep 4, 2024

Hey @konopkja,

I need some help with the quiz I'm trying to add. I successfully added the Stablecoins quiz to the quizzes page, and it's working perfectly there. However, when I added the quiz to the Stablecoins page using the StandaloneQuizWidget, it isn't displaying correctly. The quiz questions and options are showing up as in the attached image.

Screenshot (170)

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

@pettinarip

@pettinarip
Copy link
Member

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

Hey @Shiva-Sai-ssb good job and thanks for helping on this 🚀

So it looks like the only thing missing here is the i18n support for this page. You will need to manually add the stablecoing page to this condition https://github.com/ethereum/ethereum-org-website/blob/dev/src/lib/utils/translations.ts#L209 in order to load the correct translations for it.

Clarification: the quizzes page already loads this namespace, that is why it works fine there.

@Shiva-Sai-ssb
Copy link
Contributor Author

Could you please suggest what's causing this issue and how I can fix it? Thanks in advance!

Hey @Shiva-Sai-ssb good job and thanks for helping on this 🚀

So it looks like the only thing missing here is the i18n support for this page. You will need to manually add the stablecoing page to this condition https://github.com/ethereum/ethereum-org-website/blob/dev/src/lib/utils/translations.ts#L209 in order to load the correct translations for it.

Clarification: the quizzes page already loads this namespace, that is why it works fine there.

Thanks a lot for the quick response! I'll go ahead and add the Stablecoins page to the translations condition as suggested. That should hopefully resolve the issue.

Appreciate your help!

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 4, 2024
@Shiva-Sai-ssb
Copy link
Contributor Author

Hi @konopkja, @pettinarip, sorry for tagging.

I just wanted to let you know that the quiz is now working as expected on both the quizzes page and the stablecoins page.
Could you please review this PR?

@konopkja
Copy link
Contributor

perfect, looks great!! thank you so much for implementing this. People can now learn more about stablecoins in a fun way :)

@konopkja
Copy link
Contributor

konopkja commented Sep 10, 2024 •
edited
Loading

@wackerow @pettinarip d do we have to do here anything to include event tracking?

@Shiva-Sai-ssb
Copy link
Contributor Author

@wackerow @pabloped do we have to do here anything to include event tracking?

Hey, I think you might have tagged the wrong person here.

wackerow
wackerow requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @Shiva-Sai-ssb! Just left a few comments but then I think we can get this in. Nice job!

src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
@Shiva-Sai-ssb
Copy link
Contributor Author

Please review this.
@wackerow

wackerow
wackerow reviewed Oct 8, 2024
View reviewed changes
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
@Shiva-Sai-ssb
Copy link
Contributor Author

Hi @wackerow, thanks for reviewing. I see you have committed all the suggestions you mentioned. Is it done, or is there anything else I should do?

wackerow
wackerow approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it done, or is there anything else I should do?

@Shiva-Sai-ssb We're all set! As you noted, I committed a couple small adjustments... Wanted to let this build first but can pull it in now. Let me know if you disagree with any of the changes; can always continue to adjust separately as-needed.

Thanks again for the help with this @Shiva-Sai-ssb! Will be a valuable addition to the page.

@wackerow wackerow changed the title add stablecoins quiz [Fixes #13649] Feat: add stablecoins quiz [Fixes #13649] Oct 9, 2024
@wackerow wackerow added Update Crowdin PR introduces changes that need to be updated in Crowdin feature ✨ This is enhancing something existing or creating something new and removed translation 🌍 This is related to our Translation Program tooling 🔧 Changes related to tooling of the project labels Oct 9, 2024
@wackerow wackerow merged commit ee1eafc into ethereum:dev Oct 9, 2024
7 of 9 checks passed
@wackerow
Copy link
Member

wackerow commented Oct 9, 2024

@all-contributors please add @Shiva-Sai-ssb for content

@allcontributors allcontributors bot mentioned this pull request Oct 9, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @Shiva-Sai-ssb! 🎉

@Shiva-Sai-ssb Shiva-Sai-ssb deleted the fix-13649 branch October 9, 2024 08:00
@Shiva-Sai-ssb Shiva-Sai-ssb mentioned this pull request Oct 14, 2024
Open
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Oct 16, 2024
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konopkja konopkja konopkja approved these changes

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quiz for stablecoins
5 participants
@Shiva-Sai-ssb @konopkja @pettinarip @wackerow @lukassim