ui: round inner meter in ui/progress #13817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
wackerow
added
the
needs design approval 🧑🎨
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
added
design
nloureiro
removed
the
needs design approval 🧑🎨
pettinarip
approved these changes
Sep 9, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ui/progresscomponent withrounded-fullon the inner progress bar element^ Maintains this appearance from previous Chakra-UI
Progresscc: @nloureiro I didn't see this component in the DS, but noticed we previously had the rounded approach on the inside bar. Came across it when updating colors on the Quizzes page, so if we don't want to change the base component here, I can just close it out and apply to that usage only.