Design system color theming updates #13821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
each lum percentage correlates to a small range of hex codes that all round to the lum value in Figma, shows range in comments for rough equivalency
"solid" default variant, "outline" includes color, `isSecondary` removes color from default outline/ghost states
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
wackerow
added
the
design system
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
consistent with other nav items
preserve/sync order shown in Figma. Orange palette no longer needed, but three shades still being used
complementaries; preserve/sync order from Figma
required tokens have been migrated. deprecates remaining -neutral variables
deprecate single-use `button-hover` tailwind token; applied directly at ui/button component level
tw `primary`, `button-hover` shadow tokens; chakra `primary` shadow token
nloureiro
approved these changes
Sep 9, 2024
Design system: button theming
Design system: nav bar/button theming
pettinarip
approved these changes
Sep 10, 2024
Migrate EthPriceCard, update associate color tokens
pettinarip
requested changes
Sep 10, 2024
There was a problem hiding this comment.
@wackerow left a few questions on Chromatic where we have a few visual differences.
|
Good catch! Was related to the replacement for the "Close" icon in the
I changed it to use This should reach a nice compromise between keeping the new custom button styling to a minimum, while also matching it close-enough to the existing close button details. |
pettinarip
approved these changes
Sep 11, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Design system