-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage code example redesign #13844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
used before this was converted to a string; not intended as part of code example
This reverts commit 73ccfe5.
wackerow
added
needs dev approval 🧑💻
Approval from a developer is needed before merging
needs design approval 🧑🎨
Approval from a designer is needed before merging
labels
Sep 12, 2024
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
September 12, 2024 00:49
nloureiro
approved these changes
Sep 12, 2024
pettinarip
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor use clipboard
pettinarip
approved these changes
Sep 13, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs design approval 🧑🎨
Approval from a designer is needed before merging
needs dev approval 🧑💻
Approval from a developer is needed before merging
tooling 🔧
Changes related to tooling of the project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CodeModal
(partially updating to tailwind; leaving Chakra modal logic) with fresh set of pain more in line with latest theming and buttons50vh
(half the device height) to limit obtrusiveness, and ensure user has screen space available to swipe the document, and not get stuck in nested scrolling.useClipboard
hook based onusehooks-ts
library, mimicking Chakra-UI useClipboard hook.Preview link
https://deploy-preview-13844--ethereumorg.netlify.app/en/
Related issue