Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract ui/divider #13900

Merged
merged 3 commits into from
Sep 18, 2024
Merged

refactor: extract ui/divider #13900

merged 3 commits into from
Sep 18, 2024

Conversation

wackerow
Copy link
Member

Description

  • Extract re-usable Divider UI component

Related Issue

Fixes inconsistent color styling from some using old theming

@wackerow wackerow changed the base branch from dev to staging September 18, 2024 16:09
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1260c45
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66eb17f9ecea110008543cc6
😎 Deploy Preview https://deploy-preview-13900--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 44 (🔴 down 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines merged commit 79ea516 into staging Sep 18, 2024
8 of 10 checks passed
@corwintines corwintines deleted the ui-divider branch September 18, 2024 19:04
This was referenced Oct 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @corwintines