Shadcn migration - heros #13959
Merged
Shadcn migration - heros #13959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
commented
Sep 25, 2024
| title, | ||
| description, | ||
| blurDataURL, | ||
| maxHeight, |
There was a problem hiding this comment.
Removed this prop as it was not being used and was a bit hacky to set up with tw.
wackerow
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
@pettinarip Are we using this component anywhere? I don't see any instances of it
There was a problem hiding this comment.
We are not atm. But it is planned to be used once we implement the new DS styles on the docs and other pages I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the ContentHero and MdxHero component to TW.