Shadcn migrate - AssetDownload - AssetDownloadArtist - AssetDownloadImage #13960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
saurabhburade
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Thanks @saurabhburade. Pushing a cleanup commit and we are done.
| type AssetDownloadProps = { | ||
| title: string | ||
| alt: string | ||
| artistName?: string | ||
| artistUrl?: string | ||
| image: ImageProps["src"] | ||
| svgUrl?: string | ||
| } & FlexProps | ||
| } & BaseHTMLAttributes<HTMLDivElement> & { asChild?: boolean } |
There was a problem hiding this comment.
Suggested change
| } & BaseHTMLAttributes<HTMLDivElement> & { asChild?: boolean } | |
| } & BaseHTMLAttributes<HTMLDivElement> |
| px="4" | ||
| borderRadius="0 0 4px 4px" | ||
| className={cn( | ||
| "mb-4 border border-t-0 border-[#e5e5e5]", |
There was a problem hiding this comment.
Will remove these colors and leave the border default for now
Suggested change
| "mb-4 border border-t-0 border-[#e5e5e5]", | |
| "mb-4 border border-t-0", |
| > | ||
| <Flex me="2" fontSize="md" textColor="text300"> | ||
| <Flex className="me-2 text-md text-text-300"> |
There was a problem hiding this comment.
Suggested change
| <Flex className="me-2 text-md text-text-300"> | |
| <Flex className="me-2 text-md"> |
pettinarip
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AssetDownloadto tailwindAssetDownloadArtistto tailwindAssetDownloadImageto tailwind