Migrate MatomoOptOut to Shadcn #13961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimalsm
requested review from
wackerow,
corwintines and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
requested changes
Sep 25, 2024
src/components/MatomoOptOut.tsx
Outdated
| @@ -1,10 +1,11 @@ | |||
| import { useEffect, useState } from "react" | |||
| import { Checkbox, Flex } from "@chakra-ui/react" | |||
|
|
|||
| import Text from "@/components/OldText" | |||
There was a problem hiding this comment.
This one needs to be replaced by the native <p> tag
There was a problem hiding this comment.
Done and added note above.
wackerow
approved these changes
Sep 25, 2024
minimalsm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
MatomoOptOutcomponent to ShadCN from ChakraNote
As far as I can tell, the current border color for the box in Chakra theme (#e5e5e5) does not exist in DS/Tailwind theme. I've used
body-lightas the closest, but defer to @nloureiro here :)Updated Note
Per @pettinarip's comment here, I've also stopped using the
OldTextcomponent. This means the red color is slightly, though unrecognisably, different (now usingerrorfrom tailwind config instead of thefailcolor in Chakra theme), and the margin bottom (was 1.45rem) is now 1.25rem per our scale.Related Issue
#13946