Migrate UpcomingEventsList to Shadcn #13967
Conversation
minimalsm
requested review from
wackerow,
corwintines and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| import type { CommunityConference, Lang } from "@/lib/types" | ||
|
|
||
| import { Button } from "@/components/Buttons" | ||
| import EventCard from "@/components/EventCard" | ||
| import InfoBanner from "@/components/InfoBanner" |
There was a problem hiding this comment.
@pettinarip I see you used the Alert here for InfoBanner migration. InfoBanner is used over a thousand of times in our markdown files, so it is probably best we just migrate the component itself. What do you think?
There was a problem hiding this comment.
Correct, thats the plan for InfoBanner. We are going to tackle that in a differnt PR
| ) | ||
| })} | ||
|
|
||
| <Box |
There was a problem hiding this comment.
Did this do something important or just a mistake?
There was a problem hiding this comment.
Hmm good question xD I don't think this is doing anything visually, its adding just a bit of space...I think it is safe to remove it
|
|
||
| import type { CommunityConference, Lang } from "@/lib/types" | ||
|
|
||
| import { Button } from "@/components/Buttons" | ||
| import EventCard from "@/components/EventCard" | ||
| import InfoBanner from "@/components/InfoBanner" |
There was a problem hiding this comment.
Correct, thats the plan for InfoBanner. We are going to tackle that in a differnt PR
| ) | ||
| })} | ||
|
|
||
| <Box |
There was a problem hiding this comment.
Hmm good question xD I don't think this is doing anything visually, its adding just a bit of space...I think it is safe to remove it
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
Description
Migrates
UpcomingEventListto Shadcn.Note, before the H3 had a line-height of 1.4 (not really sure why). This isn't in our system, so I just left it as default line height.
Related Issue
#13946 #13966