Migrate Trilemma Triangle to Shadcn #13975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimalsm
requested review from
wackerow,
corwintines and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
added
the
needs design approval 🧑🎨
pettinarip
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
LGTM @minimalsm, will wait for a designers review before merging.
Comment on lines
+157
to
+160
| // TODO: Add all border color tokens to match DS | ||
| border: { | ||
| DEFAULT: "hsla(var(--border))", | ||
| }, |
There was a problem hiding this comment.
Curious about this, @nloureiro do we have a default color for our borders?
There was a problem hiding this comment.
this was added for the homepage and we should use on other pages too
There was a problem hiding this comment.
Ahh awesome, will add them in a separate PR.
|
looks good to me!! thank you @minimalsm :)
|
nloureiro
approved these changes
Sep 27, 2024
Comment on lines
+157
to
+160
| // TODO: Add all border color tokens to match DS | ||
| border: { | ||
| DEFAULT: "hsla(var(--border))", | ||
| }, |
There was a problem hiding this comment.
this was added for the homepage and we should use on other pages too
Comment on lines
+157
to
+160
| // TODO: Add all border color tokens to match DS | ||
| border: { | ||
| DEFAULT: "hsla(var(--border))", | ||
| }, |
nloureiro
removed
the
needs design approval 🧑🎨
fernandoguadmendezespinoza17
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
@nloureiro I took some liberties with picking colors: the current production Trilemma Triangle still uses blue for lightmode and orange for darkmode. This PR now uses purple instead, let me know if you have any suggestions/tweaks you'd like and I'll update.
Related Issue
#13946