Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadcn Migration - BeaconChainActions #13990

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Shadcn Migration - BeaconChainActions #13990

merged 3 commits into from
Sep 30, 2024

Conversation

saurabhburade
Copy link
Contributor

@saurabhburade saurabhburade commented Sep 27, 2024 •
edited
Loading

Description

Migrate BeaconChainActions component to tailwind.

Related Issue

#13946

@netlify Netlify
Copy link

netlify bot commented Sep 27, 2024 •
edited
Loading

❌ Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 86d0df1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66fa6390a679290008d703a2

@saurabhburade
Copy link
Contributor Author

saurabhburade commented Sep 27, 2024 •
edited
Loading

Findings

Screenshot 2024-09-27 at 8 03 28 PM

@saurabhburade saurabhburade marked this pull request as ready for review September 27, 2024 20:34
@pettinarip pettinarip mentioned this pull request Sep 30, 2024
Open
65 tasks
@pettinarip
Copy link
Member

Findings

Good catch @saurabhburade. Pushing a commit to fix those translations.

pettinarip
pettinarip approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @saurabhburade 🚀

@pettinarip pettinarip merged commit aed300a into ethereum:dev Sep 30, 2024
4 of 9 checks passed
This was referenced Oct 2, 2024
Merged
Merged
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurabhburade @pettinarip