Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply flip to parent of svg #14001

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: apply flip to parent of svg #14001

merged 1 commit into from
Oct 2, 2024

Conversation

wackerow
Copy link
Member

Description

  • apply RTL flip to parent of svg to avoid conflicting transitions on the svg element
  • Fixes issue where hovering on RTL pages would flip the icon back to "LTR" orientation

Related Issue

None filed

@wackerow
fix: apply flip to parent of svg
665d52f 
avoids conflicting transitions
@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 665d52f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66faca27df4ed10008778fdb
😎 Deploy Preview https://deploy-preview-14001--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 47 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

defihook

This comment was marked as spam.

Sign in to view

@corwintines corwintines merged commit 99c3c77 into dev Oct 2, 2024
8 of 10 checks passed
@corwintines corwintines deleted the rtl-animation branch October 2, 2024 05:15
This was referenced Oct 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defihook defihook defihook left review comments

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackerow @defihook @corwintines