Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DataProductCard component to shadcn/tailwind #14035

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Oct 2, 2024

Description

Migrate DataProductCard component to shadcn/tailwind

Related Issue

#13946

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 0f27599
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67073670cdd4d80007e5ee09
😎 Deploy Preview https://deploy-preview-14035--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip
Copy link
Member

@Baystef is this ready for review? asking bc it is in draft mode

@Baystef
Copy link
Contributor Author

Baystef commented Oct 4, 2024

@Baystef is this ready for review? asking bc it is in draft mode
No, it's not really ready, don't know what to replace useColorModeValue hook with. Also, I created a LinkBox / LinkOverlay component on 1 of the PRs, so if that's accepted or rejected, it'll affect how I handle LinkBox/LinkOverlay here

@pettinarip
Copy link
Member

@Baystef is this ready for review? asking bc it is in draft mode
No, it's not really ready, don't know what to replace useColorModeValue hook with. Also, I created a LinkBox / LinkOverlay component on 1 of the PRs, so if that's accepted or rejected, it'll affect how I handle LinkBox/LinkOverlay here

Got it, thanks for the quick reply. Regarding the useColorModeValue, we have a replacement here.

@Baystef Baystef marked this pull request as ready for review October 9, 2024 08:12
@Baystef
Copy link
Contributor Author

Baystef commented Oct 9, 2024

@Baystef is this ready for review? asking bc it is in draft mode

It is ready now @pettinarip

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Baystef

@pettinarip pettinarip merged commit 61a235c into ethereum:dev Oct 15, 2024
9 of 10 checks passed
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants