Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deleted /enterprise/private-ethereum/ and the menu link to it #14062

Merged
merged 4 commits into from
Oct 5, 2024
Merged

feat: Deleted /enterprise/private-ethereum/ and the menu link to it #14062

merged 4 commits into from
Oct 5, 2024

Conversation

Signor1
Copy link
Contributor

@Signor1 Signor1 commented Oct 4, 2024

Title

Delete /enterprise/private-ethereum/ and remove the menu link to it

Description

This PR removes the obsolete /enterprise/private-ethereum/ page, as it is no longer maintained and has become irrelevant in the current enterprise Ethereum landscape. Additionally, I have removed the corresponding menu link under Build > Enterprise > Private Ethereum and updated the menu so that Build > Enterprise now links directly to /enterprise.

Related Issue

This PR addresses issue #13640, which requested the retirement of the /enterprise/private-ethereum/ page and the associated menu link.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Oct 4, 2024
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 66b6a99
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67001e1da3f3900008c3ddad
😎 Deploy Preview https://deploy-preview-14062--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Signor1 Signor1 changed the title fix: Deleted /enterprise/private-ethereum/ and the menu link to it feat: Deleted /enterprise/private-ethereum/ and the menu link to it Oct 4, 2024
@github-actions github-actions bot added the translation 🌍 This is related to our Translation Program label Oct 4, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Signor1! Looks good.. I just moved the label we use in the menu, and added a redirect for the now-deprecated page. Also cleared the json strings we're not using anymore, and removed the non-english markdown pages.

Assuming this builds, pulling in!

@wackerow
Copy link
Member

wackerow commented Oct 5, 2024

@all-contributors please add @Signor1 for maintenance

@wackerow wackerow merged commit 0b7e535 into ethereum:dev Oct 5, 2024
10 checks passed
Copy link
Contributor

@wackerow

I've put up a pull request to add @Signor1! 🎉

Copy link

gitpoap-bot bot commented Oct 5, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants