Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract protected newToCrypto array #14185

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 17, 2024

Description

  • Extract newToCrypto array into new data file
  • Strictly type names based on wallets data array
  • Type-restrict ability to add this property directly to wallet entry
  • Update CODEOWNERS for approval before changes to data/wallets/new-to-crypto.ts
  • Deprecate wallets-check.yml workflow check

Preview link

https://deploy-preview-14185--ethereumorg.netlify.app/en/wallets/find-wallet/

deprecate wallets-check.yml workflow
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4e1b569
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/673b8af9cf69390008a975bd
😎 Deploy Preview https://deploy-preview-14185--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Oct 23, 2024
@corwintines corwintines merged commit c92e797 into dev Nov 18, 2024
6 checks passed
@corwintines corwintines deleted the new-to-crypto-wallets branch November 18, 2024 20:04
This was referenced Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants