Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wallet attributes icon alignments #14207

Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 21, 2024

Targets branch: walletTableAbstraction

Description

  • Prevent Info tooltip icon from wrapping on its own by forcing nowrap connection to last word in label
  • Fine adjustments to positioning of icons to improve alignment
image

Related Issue

Fixes issues seen here:
image

@wackerow wackerow changed the base branch from dev to walletTableAbstraction October 21, 2024 19:18
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4c8e15a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6716a8e44dde1c000816cfcf
😎 Deploy Preview https://deploy-preview-14207--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow marked this pull request as ready for review October 21, 2024 19:19
@wackerow
Copy link
Member Author

cc: @konopkja

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wackerow!

@corwintines corwintines merged commit 2b3caae into walletTableAbstraction Oct 21, 2024
6 of 9 checks passed
@corwintines corwintines deleted the walletTableAbstraction-info-icon branch October 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants