Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: include mocks in Netlify deploys #14211

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Patch: include mocks in Netlify deploys #14211

merged 1 commit into from
Oct 22, 2024

Conversation

pettinarip
Copy link
Member

Currently our page revalidation does not work in preview deploy contexts (or envs using USE_MOCK_DATA) because the mocks are not found.

Description

This PR includes the mock files.

@github-actions github-actions bot added the config ⚙️ Changes to configuration files label Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9e52d04
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67175eb5bd425f00088ddff2
😎 Deploy Preview https://deploy-preview-14211--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 54 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow merged commit dfddcd1 into dev Oct 22, 2024
6 checks passed
@wackerow wackerow deleted the patch-mocks branch October 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants