Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO update meta titles #14228

Merged
merged 6 commits into from
Dec 17, 2024
Merged

SEO update meta titles #14228

merged 6 commits into from
Dec 17, 2024

Conversation

pettinarip
Copy link
Member

Description

Adds meta titles to md pages and a few react pages.

Related Issue

#13796

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a86f305
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/671a195c83ad860008c15a96
😎 Deploy Preview https://deploy-preview-14228--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@konopkja
Copy link
Contributor

@pettinarip

the table in the issue defining titles had few formating issues here on github and hid full titles for few URLs:

What are NFTs? | Benefits and use
What is a DAO? | Decentralized Autonomous Organization
How to use Ethereum Wallets | Step by Step
List of Ethereum Wallets | ethereum.org
What is DeFi? | Benefits and Use of Decentralised Finance

@pettinarip
Copy link
Member Author

@pettinarip

the table in the issue defining titles had few formating issues here on github and hid full titles for few URLs:

What are NFTs? | Benefits and use What is a DAO? | Decentralized Autonomous Organization How to use Ethereum Wallets | Step by Step List of Ethereum Wallets | ethereum.org What is DeFi? | Benefits and Use of Decentralised Finance

@konopkja ah ok, I see. Will update those.

Just to clarify, in all these pages we automatically concatenate the text | ethereum.org to the meta titles. So, for example, "What are NFTs? | Benefits and use" would become "What are NFTs? | Benefits and use | ethereum.org".

Is this ok? or would you think it would be better to use " | ethereum.org" only on pages we consider appropriate?

@konopkja
Copy link
Contributor

konopkja commented Oct 25, 2024

@pettinarip
the table in the issue defining titles had few formating issues here on github and hid full titles for few URLs:
What are NFTs? | Benefits and use What is a DAO? | Decentralized Autonomous Organization How to use Ethereum Wallets | Step by Step List of Ethereum Wallets | ethereum.org What is DeFi? | Benefits and Use of Decentralised Finance

@konopkja ah ok, I see. Will update those.

Just to clarify, in all these pages we automatically concatenate the text | ethereum.org to the meta titles. So, for example, "What are NFTs? | Benefits and use" would become "What are NFTs? | Benefits and use | ethereum.org".

Is this ok? or would you think it would be better to use " | ethereum.org" only on pages we consider appropriate?

only on those pages we consider appropriate, not everywhere

@pettinarip
Copy link
Member Author

| ethereum.org

Ok @konopkja, pushed those changes.

To confirm, by removing the default "| ethereum.org", from now on the only page that will have this is the find wallet page that has "List of Ethereum Wallets | ethereum.org". The rest will no longer have it.

LMK if you would like to add more pages into this group.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/676119333f219a1a3e077b17
😎 Deploy Preview https://deploy-preview-14228--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 28, 2024
@corwintines corwintines self-assigned this Dec 17, 2024
@corwintines
Copy link
Member

https://app.netlify.com/sites/ethereumorg/deploys/676119333f219a1a3e077b17

There was a failing API key causing this to not build. Fixed that and now its building, so going to merge.

@corwintines corwintines merged commit efb623b into dev Dec 17, 2024
5 of 10 checks passed
@corwintines corwintines deleted the meta-titles branch December 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants