Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wallet-data.ts - phantom #14264

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Update wallet-data.ts - phantom #14264

merged 1 commit into from
Oct 31, 2024

Conversation

konopkja
Copy link
Contributor

@konopkja konopkja commented Oct 30, 2024 •
edited by wackerow
Loading

Related Issue

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

❌ Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 9e4ff50
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/672216b4d303a700086b8ca7

@wackerow
Copy link
Member

wackerow commented Oct 31, 2024 •
edited
Loading

Erroring because of the language codes that were added (ha and yo, both supported languages) are not yet added to the Lang type required here.

^ Fixes this; blocking this PR briefly until that PR is merged.

@corwintines corwintines self-assigned this Oct 31, 2024
@corwintines
Copy link
Member

@wackerow merged that PR in, so going to merge this. Thanks for that!

@corwintines corwintines merged commit e33142a into dev Oct 31, 2024
2 of 7 checks passed
@corwintines corwintines deleted the konopkja-patch-7 branch October 31, 2024 15:23
This was referenced Nov 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@corwintines corwintines

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest a wallet
3 participants
@konopkja @wackerow @corwintines