Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a page for payments use-case #14370

Merged
merged 9 commits into from
Dec 18, 2024
Merged

Conversation

MukulKolpe
Copy link
Contributor

Description

Implemented a new page for the Ethereum Payments (/payments) use-case.

Content worked on here: #13653 by @BoluwatifeInferno.

Design and content of the page:
https://www.figma.com/design/PlJHPXisq7b5ual2DjrR9F/payments?node-id=12940-869&t=J998WMcKEFD6c0jn-1

Related Issue

Resolves #14217

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2f75794
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6762466188604d000885a01e
😎 Deploy Preview https://deploy-preview-14370--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 52 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@konopkja
Copy link
Contributor

I wanted to review this but preview is broken

@konopkja
Copy link
Contributor

@MukulKolpe do you think you can still look at this or should core devs take over here?

@MukulKolpe
Copy link
Contributor Author

I wanted to review this but preview is broken

Thanks for pointing that out. It should be fixed now. Let me know what you think!

@MukulKolpe
Copy link
Contributor Author

@MukulKolpe do you think you can still look at this or should core devs take over here?

For sure! Let me know if I've missed anything or if any adjustments are needed.

@konopkja
Copy link
Contributor

@konopkja
Copy link
Contributor

konopkja commented Dec 16, 2024

change request:

  • max width 320px for image
  • remove "ethereum in action" title and its one sentence

class
max-w-80 | max-width: 20rem; /* 320px */

Screenshot 2024-12-16 at 13 44 17

public/content/payments/index.md Outdated Show resolved Hide resolved
@corwintines corwintines self-assigned this Dec 17, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MukulKolpe

@corwintines corwintines merged commit 9719dac into ethereum:dev Dec 18, 2024
9 of 10 checks passed
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new page for payments use case
3 participants