Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to weekly active addresses and smaller growthepie API endpoint #14478

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mseidlx
Copy link
Contributor

@mseidlx mseidlx commented Dec 10, 2024

Switch to weekly active addresses and smaller growthepie API endpoint

Description

  • switching to "fundamentals" endpoint instead of "fundamentals_full" - it's a smaller endpoint but still has all required data.
  • using "aa_last7d" (Active Addresses last 7 days) instead of "daa" (Daily Active Addresses) since you are referring to this datapoint as weekly active addresses on your page
  • small naming fix "growthepie" is how we ideally refer to our platform :)

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cc0343d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6758179ec799590008bc394c
😎 Deploy Preview https://deploy-preview-14478--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🔴 down 13 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Dec 18, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks @mseidlx

@corwintines
Copy link
Member

@all-contributors can you add @mseidlx for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @mseidlx! 🎉

@corwintines corwintines merged commit 3497a53 into ethereum:dev Dec 18, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Dec 18, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants