Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Custom quiz explanation override [Fixes #14490] #14492

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix: Custom quiz explanation override [Fixes #14490] #14492

merged 2 commits into from
Dec 18, 2024
+50 −14

Conversation

wackerow
Copy link
Member

Description

  • Adds explanationOverrides to QuestionBankConfig type
  • Enables re-use of any explanations within a question set for other question, with the most common pattern so far being re-use of a single explanation for all answer choices.

Related Issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Dec 12, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e9646a8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/675a707ed5c9d3000832d25e
😎 Deploy Preview https://deploy-preview-14492--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 50 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 11 from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

minimalsm
minimalsm approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@corwintines corwintines merged commit 279ea64 into dev Dec 18, 2024
6 checks passed
@corwintines corwintines deleted the quiz-patch branch December 18, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing explanation text on 'Run a node' quiz
3 participants
@wackerow @minimalsm @corwintines