chore: Update Pillar Wallet [Fixes #14360] #14543
Conversation
arddluma
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/data/wallets/wallet-data.ts
Outdated
| twBackgroundColor: "bg-[#7501D9]", | ||
| twGradiantBrandColor: "from-[#7501D9]", | ||
| twBackgroundColor: "bg-[#6A12D0]", | ||
| twGradiantBrandColor: "from-[#6A12D0]", | ||
| url: "https://www.pillar.fi/", | ||
| active_development_team: true, | ||
| languages_supported: ["en", "bs", "zh"], |
There was a problem hiding this comment.
| languages_supported: ["en", "bs", "zh"], | |
| languages_supported: ["en"], |
There was a problem hiding this comment.
based on the #14360 I see only english support, @arddluma and @alexandradev can you confirm and modify this
There was a problem hiding this comment.
hello there,
Please check this screenshot from pillar wallet
There was a problem hiding this comment.
i see, so the issue was filled out incorrectly?
There was a problem hiding this comment.
yes, apologies for that!
There was a problem hiding this comment.
ok no worries, i see 4 languages on the screenshot while only 3 in the metadata, could you pls update it with the missing lang code?
There was a problem hiding this comment.
done sir, the missing language is Amharic. I have just added it, do you mind checking it please?
|
Hey @konopkja , I see that merging is blocked ? |
ofc only the core team can merge, nothing else from your side at this point i think. One of our devs will review and merge |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic High Entropy Secret | 602d37b | src/data/community-events.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Description
Updated Pillar Wallet logo and features
Related Issue
#14360