Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rss parsing logic #14631

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix rss parsing logic #14631

merged 1 commit into from
Jan 21, 2025

Conversation

JoeChenJ
Copy link
Contributor

@JoeChenJ JoeChenJ commented Jan 9, 2025

Description

Fixed the RSS parsing image logic for medium feeds

Before:
883923cfd9bf2e7f1147828611e484b

After:
0eac9077d63acac2c58707a8986284d

Related Issue

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jan 9, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 88992ee
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/677f44802a3844000848d7ce
😎 Deploy Preview https://deploy-preview-14631--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 49 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

corwintines
corwintines approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoeChenJ

@corwintines corwintines merged commit cb413ed into ethereum:dev Jan 21, 2025
6 checks passed
This was referenced Jan 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@Afeter8 Afeter8 Afeter8 approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeChenJ @corwintines @Afeter8