Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gas page to Tailwind/Shadcn #14836

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Feb 7, 2025

Description

Migrate Gas page to Tailwind/Shadcn

Related Issue

#13946

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 75e916a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67aa1a771c99a300082ae60b
😎 Deploy Preview https://deploy-preview-14836--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 6 from production)
Accessibility: 95 (🟢 up 3 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Baystef good job on adding the TableCaption component there. There is a small issue with the positioning but it looks great.

src/components/ui/Table.tsx Outdated Show resolved Hide resolved
src/pages/gas.tsx Outdated Show resolved Hide resolved
@Baystef Baystef requested a review from pettinarip February 10, 2025 15:51
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Baystef!

@pettinarip pettinarip merged commit 25057bd into ethereum:dev Feb 10, 2025
10 checks passed
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants