Update the gas page with an explanation of EIP 1559 #3104
Conversation
qbzzt
requested review from
GeorgeTrotter,
jjmstark,
ryancreatescopy,
samajammin and
wackerow
as code owners
github-actions
bot
added
Status: Review Needed
content 🖋️
|
This is a perfect summary IMO :) |
| | A | 90 gwei | 90 gwei | N/A | N/A | This transaction is not going in the block | | ||
| | B | 200 gwei | 5 gwei | 5 gwei | 105 gwei | The priority fee is the maximum priority fee | | ||
| | C | 120 gwei | 30 gwei | 20 gwei | 120 gwei | The priority fee is the maximum (total) fee minus the base fee | | ||
| | D | gas price = 200 gwei | gas price = 200 gwei | 100 gwei | 200 gwei | Transactions that specify gas price are charged the full amount | |
There was a problem hiding this comment.
Did you mean to include "gas price = " on only two of these cells?
There was a problem hiding this comment.
Yes, because only transaction D is old style and actually has a gas price field. I added to the paragraph that introduces the table to clarify.
There was a problem hiding this comment.
@qbzzt Curious if you agree with the comment I left about including a line about the current block size limit doubling, then targeting 50% of this. Also one other suggestion for an edit.
Sorry for the delays on this, but took another look myself and other than small note above I think it looks solid. Personally would like to get this up sooner than later as London is rapidly approaching.
| that compares the size of the previous block (the amount of gas used for all the transactions) with a target size. If the block size is higher than the target, there | ||
| is more demand for inclusion in the blockchain than supply so the base fee, is increased. If the block size is lower than the target then there is more supply |
There was a problem hiding this comment.
If the block size is higher than the target, there is more demand for inclusion in the blockchain than supply so the base fee, is increased.
Perhaps we should note somewhere in here that max block size doubles with this upgrade, and the "target" is 50% of this, allowing for dynamic block sizes.
Consider changing the end of this sentence to (note comma placement too)
"...there is more demand for inclusion in the blockchain than supply, so the base fee in the following block is increased."
|
@samajammin Have any thoughts on this content update? https://hackmd.io/@q8X_WM2nTfu6nuvAzqXiTQ/1559-wallets I found that link to be helpful as a confirmatory resource |
|
@wackerow ya I trust your judgement. Agree let's get this content merged sooner rather than later. Good is better than perfect 😀 |
|
👷 Deploy request for netlify-edge-ethereum-org pending review. 🔨 Explore the source changes: c787e12 |
github-actions
bot
added
the
translation 🌍
Description
Update the gas price section with the details for EIP 1559, as well as a brief explanation of the reason for the change.
Related Issue
#3022