Enable Gatsby functions in preview deploys #4919

pettinarip · 2021-12-29T17:01:20Z

Description

Currently we have the Netlify functions working in the Netlify context/server. On the other hand, in our preview deploys context (Gatsby Cloud) they are not working. We need to integrate them. This PR addresses this issue.

Added api folder to enable functions in gatsby cloud.
New env var GATSBY_FUNCTIONS_PATH to determine the path of the functions in each environment.
- In Netlify: /.netlify/functions
- In GC: /api

HOW TO TEST IT:

Enter https://www.gatsbyjs.com/dashboard and use the site: pettinarip-ethereum-org-website-dev
Change GATSBY_FUNCTIONS_PATH env var to /api => wait the build to finish => test the preview deploy
Change GATSBY_FUNCTIONS_PATH env var to /.netlify/functions => wait the build to finish => test the netlify deploy (netlify url https://pettinarip-eth-org.netlify.app)
In our prod deploy we will have 2 sites, one for our preview deploys and another for the prod ones

PROD IMPLEMENTATION:

ethereum-org-website-master: GATSBY_FUNCTIONS_PATH=/.netlify/functions
ethereum-org-website-dev: GATSBY_FUNCTIONS_PATH=/api

gatsby-cloud · 2021-12-29T17:07:38Z

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 6m

Performance

Lighthouse report

Metric	Score
Performance	🔶 25
Accessibility	💚 97
Best Practices	💚 93
SEO	🔶 85

🔗 View full report

pettinarip · 2021-12-29T17:22:04Z

~~Last successful build: https://build-fb029333-c741-4c84-a19c-959909c87fa9.gtsb.io/en/~~

minimalsm · 2022-01-26T16:20:42Z

@pettinarip the URL you've provided to test is re-directing to Gatsby cloud dashboard

On the deploy preview, the StatsBox is working 🎉🎉 The Roadmap isn't for me :( (returns a 500)

samajammin · 2022-01-28T00:53:05Z

Homepage stats are working on
https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/contributing/translation-program
https://pettinarip-eth-org.netlify.app/en/
Thought I'm not seeing the API requests in browser network tab 🤔

Translations endpoint is failing (500) for me on:
https://pettinarip-eth-org.netlify.app/en/contributing/translation-program/

Also failing on:
https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/contributing/translation-program

Roadmap endpoint is failing (500) for me on:
https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/about
https://pettinarip-eth-org.netlify.app/en/about/

samajammin · 2022-01-28T00:55:34Z

src/api/etherscan.js

@@ -0,0 +1,8 @@
+import { handler as lambda } from "../lambda/etherscan"


Glad to see we can re-use the code 😄

wackerow · 2022-01-28T23:52:30Z

@samajammin It may be the cache functionality... it doesn't refetch every time you reload...
New private browser:

Then after refresh:

Also...
Getting the same on the contributing/translation-program pages, Status 500 but then the message shows

{"msg":"Request failed with status code 404"}

And on the about pages, status 500 and...

{"msg": "Request failed with status code 401"}

pettinarip · 2022-01-31T22:04:30Z

Hey sorry about that @samajammin and @wackerow. I forgot to add some env vars in my netlify account. Now everything should be working.

Thought I'm not seeing the API requests in browser network tab

@samajammin you might need to test what Paul said. I see them in my browser 🤔

samajammin

Looks close!

Everything I tested on https://pettinarip-eth-org.netlify.app/ appears to be working 👍

The roadmap endpoint on https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/about isn't working for me:

Any idea why the 500 error? This response from the endpoint is:

{"msg":"Request failed with status code 401"}

samajammin · 2022-02-02T01:45:25Z

@pettinarip the translations endpoint on https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/contributing/translation-program/ is also still failing for me:

The response from the endpoint is:

{"msg":"Request failed with status code 404"}

pettinarip · 2022-02-02T14:33:15Z

@samajammin yes, probably this is a bit tricky to test because we are using just 1 Gatsby Cloud site to test 2 different envs.

So, right now the GC site (pettinarip-ethereum-org-website-dev) is setup to be used in Netlify context.

If you want to test the preview deploys (GC context), you need to update the GATSBY_FUNCTIONS_PATH to be /api.

This idea requires 2 GC sites.

1 GC site for Netlify (ethereum-org-website-prod)
1 GC site for the preview deploys (ethereum-org-website-dev)

We won't have a GC site that works with both hosting envs.

Let me know if this doesn't make sense to you and we can discuss it on a call.

samajammin · 2022-02-02T15:21:16Z

Makes sense, so can't we set up this PR preview deploy to be the GC preview test (ethereum-org-website-dev)?

I suppose that was my assumption:

pettinarip-ethereum-org-website-dev to test Netlify functions context
ethereum-org-website-dev (i.e. this PR's preview deploy) to test Gatsby functions context

samajammin · 2022-02-23T15:41:28Z

IIRC, some ENV variables are not working in Gatsby Cloud. This isn't a bug on our end - we're still waiting on Gatsby Cloud support for resolution here, correct @pettinarip? If so, could you please update this PR to a draft?

samajammin · 2022-02-28T17:43:43Z

Marking as blocked - still waiting on a response from Gatsby Cloud.

pettinarip · 2022-03-07T23:14:28Z

PR unblocked. Functions working in both envs now.

Preview deploy: https://ethereumorgwebsitedev01-pettinaripethereumorgwebsitefu.gtsb.io/en/
Netlify: https://pettinarip-eth-org.netlify.app/en/

samajammin · 2022-03-08T17:41:29Z

@pettinarip all functions are giving me a 500 on https://pettinarip-eth-org.netlify.app/en/ - they're working for you?

samajammin

Working now!

github-actions bot added the review needed 👀 label Dec 29, 2021

pettinarip force-pushed the functions-support-gc branch from 85d5705 to 3237e62 Compare December 29, 2021 17:15

wackerow mentioned this pull request Jan 5, 2022

[WIP] GC functions testing #4982

Closed

pettinarip mentioned this pull request Jan 24, 2022

Enable Gatsby functions in preview deploys #5203

Closed

pettinarip force-pushed the functions-support-gc branch from 69b4269 to 3237e62 Compare January 26, 2022 14:30

pettinarip marked this pull request as ready for review January 26, 2022 14:45

pettinarip requested review from corwintines, minimalsm, samajammin and wackerow as code owners January 26, 2022 14:45

samajammin reviewed Jan 28, 2022

View reviewed changes

samajammin suggested changes Feb 2, 2022

View reviewed changes

pettinarip force-pushed the functions-support-gc branch from 3237e62 to 5b72e28 Compare February 2, 2022 20:22

github-actions bot added the dependencies 📦 Changes related to project dependencies label Feb 9, 2022

minimalsm added the Status: Blocked 🛑 This is blocked label Feb 28, 2022

minimalsm marked this pull request as draft February 28, 2022 17:43

pettinarip added 3 commits March 7, 2022 19:22

add api folder to enable functions in gatsby cloud

0b9d89c

bump gatsby version

6a71026

pass env vars to lambdas as args

6543f9b

pettinarip force-pushed the functions-support-gc branch from 6dea794 to 6543f9b Compare March 7, 2022 22:23

add ref to GC bug

0c576ed

pettinarip marked this pull request as ready for review March 7, 2022 23:12

pettinarip removed the Status: Blocked 🛑 This is blocked label Mar 7, 2022

pettinarip requested a review from samajammin March 7, 2022 23:14

samajammin approved these changes Mar 8, 2022

View reviewed changes

samajammin merged commit 7d6899e into ethereum:dev Mar 8, 2022

minimalsm mentioned this pull request Mar 22, 2022

Deploy v3.17.0 #5723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Gatsby functions in preview deploys #4919

Enable Gatsby functions in preview deploys #4919

pettinarip commented Dec 29, 2021 •

edited

Loading

gatsby-cloud bot commented Dec 29, 2021 •

edited

Loading

pettinarip commented Dec 29, 2021 •

edited

Loading

minimalsm commented Jan 26, 2022

samajammin commented Jan 28, 2022

samajammin Jan 28, 2022

wackerow commented Jan 28, 2022

pettinarip commented Jan 31, 2022

samajammin left a comment

samajammin commented Feb 2, 2022

pettinarip commented Feb 2, 2022 •

edited

Loading

samajammin commented Feb 2, 2022 •

edited

Loading

samajammin commented Feb 23, 2022 •

edited

Loading

samajammin commented Feb 28, 2022

pettinarip commented Mar 7, 2022

samajammin commented Mar 8, 2022

samajammin left a comment

		@@ -0,0 +1,8 @@
		import { handler as lambda } from "../lambda/etherscan"

Enable Gatsby functions in preview deploys #4919

Enable Gatsby functions in preview deploys #4919

Conversation

pettinarip commented Dec 29, 2021 • edited Loading

Description

gatsby-cloud bot commented Dec 29, 2021 • edited Loading

Gatsby Cloud Build Report

Build Details

Performance

Lighthouse report

pettinarip commented Dec 29, 2021 • edited Loading

minimalsm commented Jan 26, 2022

samajammin commented Jan 28, 2022

samajammin Jan 28, 2022

Choose a reason for hiding this comment

wackerow commented Jan 28, 2022

pettinarip commented Jan 31, 2022

samajammin left a comment

Choose a reason for hiding this comment

samajammin commented Feb 2, 2022

pettinarip commented Feb 2, 2022 • edited Loading

samajammin commented Feb 2, 2022 • edited Loading

samajammin commented Feb 23, 2022 • edited Loading

samajammin commented Feb 28, 2022

pettinarip commented Mar 7, 2022

samajammin commented Mar 8, 2022

samajammin left a comment

Choose a reason for hiding this comment

pettinarip commented Dec 29, 2021 •

edited

Loading

gatsby-cloud bot commented Dec 29, 2021 •

edited

Loading

pettinarip commented Dec 29, 2021 •

edited

Loading

pettinarip commented Feb 2, 2022 •

edited

Loading

samajammin commented Feb 2, 2022 •

edited

Loading

samajammin commented Feb 23, 2022 •

edited

Loading