Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/lang: create a ruby page #5387

Merged
merged 9 commits into from
Mar 4, 2022
Merged

dev/lang: create a ruby page #5387

merged 9 commits into from
Mar 4, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Feb 10, 2022

Description

Creates the page "Ethereum for Ruby Developers."

Related Issue

fix #1116 #1300

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Feb 10, 2022
@q9f q9f marked this pull request as ready for review February 10, 2022 14:09
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 10, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 7m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 85

🔗 View full report

@corwintines
Copy link
Member

Hey @q9f. Going to convert this to draft as your description says WIP. Please update when ready.

@corwintines corwintines marked this pull request as draft February 18, 2022 17:57
@q9f
Copy link
Contributor Author

q9f commented Feb 18, 2022

Ooops, forgot to remove the WIP note when I marked the PR as ready.

@q9f q9f marked this pull request as ready for review February 18, 2022 18:02
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @q9f ❤️❤️❤️❤️ noticed a few problems with our template that I've suggested changes for but nothing major.

Could you add this to the developer-docs-links YAML file to that it appears in the side navigation?

description: Learn how to develop for Ethereum using Ruby-based projects and tooling.
lang: en
sidebar: true
incomplete: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you've marked this as incomplete in the frontmatter. This displays a banner at the top of the page and a call to action at the bottom of the page. I'll default to you as the expert on the Ruby Ethereum ecosystem here — would you say it is accurate to call this page incomplete?

Screenshot 2022-02-22 at 11 33 12

Screenshot 2022-02-22 at 11 34 29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this page is fairly complete now. :-)

@minimalsm
Copy link
Contributor

@q9f just pinging to make sure you've seen this 🙏


Need a more basic primer first? Check out [ethereum.org/learn](/learn/) or [ethereum.org/developers](/developers/).

- [Blockchain Explained](https://kauri.io/article/d55684513211466da7f8cc03987607d5/blockchain-explained)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link internally here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do anything here @q9f, this was just a note to myself.

@q9f
Copy link
Contributor Author

q9f commented Mar 1, 2022

@q9f just pinging to make sure you've seen this pray

Thank you for the reviews! I'll address them by end of the week!

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging @q9f, thanks again 🎉🎉🎉🎉

Be sure to claim your 2022 POAPs also 🥳!

@minimalsm minimalsm merged commit e1b1478 into ethereum:dev Mar 4, 2022
@minimalsm
Copy link
Contributor

@all-contributors please add @q9f for code, docs

@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @q9f! 🎉

@minimalsm minimalsm mentioned this pull request Mar 4, 2022
@q9f q9f deleted the q9f/dev/ruby branch March 4, 2022 18:26
@samajammin samajammin mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum for Ruby developers
4 participants