Added ABI explanation to transactions page #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbzzt
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
minimalsm
requested changes
Mar 7, 2022
| The rest of the calldata is the arguments, [encoded as specified in the ABI specs](https://docs.soliditylang.org/en/v0.8.12/abi-spec.html#formal-specification-of-the-encoding). | ||
|
|
||
| For example, lets look at [this transaction](https://etherscan.io/tx/0xd0dcbe007569fcfa1902dae0ab8b4e078efe42e231786312289b1eee5590f6a1). | ||
| Use **Click to see More** to see the calldata. |
There was a problem hiding this comment.
Wow etherscan capitalising the word more here is giving me bad feels 😅
There was a problem hiding this comment.
Me too, but they can claim it's title case.
| 000000000000000000000000000000000000000000000000000000003b0559f4 | ||
| ``` | ||
|
|
||
| According to the specifications integer nunbers, such as addresses, appear in the ABI as 32 byte words. |
There was a problem hiding this comment.
This sentence doesn't make sense @qbzzt, I'm not sure what it is supposed to say?
minimalsm
reviewed
Mar 7, 2022
minimalsm
reviewed
Mar 7, 2022
minimalsm
approved these changes
Mar 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to the transactions page a description of what calldata means (in most cases)