Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus when tabbing through content to network statistic section [Fixes #4229] #5619

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

vluna
Copy link
Contributor

@vluna vluna commented Mar 8, 2022

Description

  • Remove outline: none to Button component in network statistics graph on home page. This will allow to show focus when tabbing.

Related Issue

#4229

@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 8, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18m

Performance

Lighthouse report

Metric Score
Performance 🔶 25
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 85

🔗 View full report

@vluna vluna marked this pull request as ready for review March 9, 2022 15:43
@vluna
Copy link
Contributor Author

vluna commented Mar 9, 2022

@minimalsm not sure if this is all what is needed. Please confirm, if not I can work on whatever is missing/not functional

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vluna.

@minimalsm minimalsm merged commit fb8b615 into ethereum:dev Mar 9, 2022
@minimalsm minimalsm mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants