-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer 2 page #5656
Layer 2 page #5656
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
src/pages/layer-2.js
Outdated
<StatsContainer> | ||
<StatBox> | ||
<StatPrimary>{tvl}</StatPrimary> | ||
<StatDescription>TVL locked in layer 2</StatDescription> | ||
</StatBox> | ||
<StatDivider /> | ||
<StatBox> | ||
<StatPrimary>{averageFee}</StatPrimary> | ||
<StatDescription> | ||
Average layer 2 ETH transfer fee | ||
</StatDescription> | ||
</StatBox> | ||
<StatDivider /> | ||
<StatBox> | ||
<StatPrimary>{percentChangeL2}</StatPrimary> | ||
<StatDescription>Layer 2 TVL Last 30 days</StatDescription> | ||
</StatBox> | ||
</StatsContainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the currency denomination below into the StatsDescription
.
In my eyes, the purpose of these stats is to alert the user of how much cheaper and trusted L2 already is. However, on the Stat itself the currency denomination has the same prominence as the actual value we're trying to communicate, making it less impactful.
I think it's fine because most users of Ethereum understand that crypto denominations are often in USD. (For example, Europeans never think about the price of ETH in terms of £/€ but in $USD). And if not, it's always close by in description anyway.
Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
src/pages/layer-2.js
Outdated
the layer 1 blockchain. | ||
</p> | ||
<p> | ||
Ethereum also functions as a data availability layer for Layer 2s, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section still confuses me a bit, particularly if there are any disputes on previous transactions
... what do we mean by previous transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this make sense?
Ethereum also functions as a data availability layer for layer 2s, so if there are any disputes on layer 2 transactions, data is provided from Ethereum for these disputes.
I'm not certain that still works... again, a bit confused about what we're trying to say here.
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Another nitpick - I think the tags/pills would look better directly under the title. It's good for fast reference & they'd all be evenly aligned. Curious what @nloureiro @konopkja think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close! A few final suggestions.
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
Layer 2 page for "Use Ethereum"
Preview deploy:
https://ethereumorgwebsitedev01-layer2page.gtsb.io/en/layer-2/
Related Issue
#5105 - Onboard onto Layer 2