Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer 2 page #5656

Merged
merged 94 commits into from
Mar 31, 2022
Merged

Layer 2 page #5656

merged 94 commits into from
Mar 31, 2022

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Mar 11, 2022

Description

Layer 2 page for "Use Ethereum"

Preview deploy:
https://ethereumorgwebsitedev01-layer2page.gtsb.io/en/layer-2/

Related Issue

#5105 - Onboard onto Layer 2

@corwintines corwintines changed the title Layer 2 page [WIP] Layer 2 page Mar 11, 2022
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Mar 11, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 11, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 20
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 85

🔗 View full report

src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
Comment on lines 359 to 376
<StatsContainer>
<StatBox>
<StatPrimary>{tvl}</StatPrimary>
<StatDescription>TVL locked in layer 2</StatDescription>
</StatBox>
<StatDivider />
<StatBox>
<StatPrimary>{averageFee}</StatPrimary>
<StatDescription>
Average layer 2 ETH transfer fee
</StatDescription>
</StatBox>
<StatDivider />
<StatBox>
<StatPrimary>{percentChangeL2}</StatPrimary>
<StatDescription>Layer 2 TVL Last 30 days</StatDescription>
</StatBox>
</StatsContainer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the currency denomination below into the StatsDescription.

In my eyes, the purpose of these stats is to alert the user of how much cheaper and trusted L2 already is. However, on the Stat itself the currency denomination has the same prominence as the actual value we're trying to communicate, making it less impactful.

I think it's fine because most users of Ethereum understand that crypto denominations are often in USD. (For example, Europeans never think about the price of ETH in terms of £/€ but in $USD). And if not, it's always close by in description anyway.

Screenshot 2022-03-31 at 11 22 22

Screenshot 2022-03-31 at 11 24 08

src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
corwintines and others added 4 commits March 31, 2022 14:20
Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
src/pages/layer-2.js Outdated Show resolved Hide resolved
the layer 1 blockchain.
</p>
<p>
Ethereum also functions as a data availability layer for Layer 2s,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section still confuses me a bit, particularly if there are any disputes on previous transactions... what do we mean by previous transactions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this make sense?

Ethereum also functions as a data availability layer for layer 2s, so if there are any disputes on layer 2 transactions, data is provided from Ethereum for these disputes.

I'm not certain that still works... again, a bit confused about what we're trying to say here.

src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
src/pages/layer-2.js Outdated Show resolved Hide resolved
corwintines and others added 3 commits March 31, 2022 14:49
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
src/pages/layer-2.js Outdated Show resolved Hide resolved
corwintines and others added 2 commits March 31, 2022 14:50
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
src/pages/layer-2.js Outdated Show resolved Hide resolved
@samajammin
Copy link
Member

Another nitpick - I think the tags/pills would look better directly under the title. It's good for fast reference & they'd all be evenly aligned. Curious what @nloureiro @konopkja think.
Screen Shot 2022-03-31 at 1 53 25 PM
FWIW I don't think updating this is a blocker from merging.

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! A few final suggestions.

corwintines and others added 3 commits March 31, 2022 14:57
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@samajammin samajammin merged commit 9e0c8c5 into dev Mar 31, 2022
@samajammin samajammin deleted the layer-2-page branch March 31, 2022 21:30
@corwintines corwintines mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants