-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy v3.18.0 #5738
Merged
Deploy v3.18.0 #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Replaced "un guía", which in Spanish would refer to a person who acts as a guide, with "una guía" which refers to a guide as an object/concept. Also removed the ";" as I think it's being misused here, I believe the phrase works better when expressed in Spanish rather than directly translated. Also I added a 1 at the end of the min ETH purchase value.
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
edit typo
The paragraph about gas saving by packing variables refers to three variables, `reserve0`, `reserve1`, and `blockTimestampLast`, and is moved up to be closer to the relevant code chunks. `kLast` is a regular uint256 and not packed in a single slot with other variables.
In Solidity 0.5, `uint112(-1)` is `2^112 - 1`, not `2^111` and it is 5.19*10^33, not 2.5*10^33.
Fixed an event date 📅 As reported by the website https://deficon.nyc/ , the DeFiCon event will take place on 7-8 May 2022. Most likely, the date error was associated from here: https://www.eventbrite.com/e/deficon-2022-tickets-164176080075
Fix event date inconsistency
Fix typo on DeFi usecase page (Russian)
docs: add brian7346 as a contributor for doc, translation
Adding Alchemy and Alphabetical Order
Fix small typo on EthExchanges
Fix broken links
Refactor to avoid using ids in the search inputs
Fixed incorrectly referring uint112(-1) as 2^111
Add FeedbackCard to all langs (developer docs)
Moved up the gas expense paragraph; removed kLast reference
minimalsm
requested review from
samajammin,
wackerow,
corwintines and
pettinarip
as code owners
March 23, 2022 15:30
wackerow
previously approved these changes
Mar 23, 2022
docs: add tnkrxyz as a contributor for doc
github-actions
bot
added
content 🖋️
This involves copy additions or edits
dependencies 📦
Changes related to project dependencies
documentation 📖
translation 🌍
This is related to our Translation Program
labels
Mar 23, 2022
wackerow
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content 🖋️
This involves copy additions or edits
dependencies 📦
Changes related to project dependencies
translation 🌍
This is related to our Translation Program
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Changes
🌐 Translations
🦄 Contributors
Thank you @brian7346, @btandowsky, @eduardopelitti, @jhonnyvianello, @minimalsm, @pettinarip, @tnkrxyz and @wackerow for the contributions! 🏆