404 redirect bug

[corwintines]

Description

• Fix redirects on pages that dont exist to properly 404

https://6295310882fe9e2a5c53ad57--ethdotorg-corwin-test.netlify.app/en/testsestse
Can test with the above link, personal Netlify deploy to test production behaviour.

Related Issue

[gatsby-cloud]

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12m

Performance

Lighthouse report

Metric	Score
Performance	🔶 24
Accessibility	💚 100
Best Practices	💚 100
SEO	💚 92

🔗 View full report

[corwintines]

Test with linked Netlify deploy in description :)

[pettinarip]

@corwintines I think that now it is always resolving a 404.

// valid url
curl -I https://6295310882fe9e2a5c53ad57--ethdotorg-corwin-test.netlify.app/en/staking
HTTP/2 404

// invalid url, correct response
curl -I https://6295310882fe9e2a5c53ad57--ethdotorg-corwin-test.netlify.app/asadasd
HTTP/2 404

// invalid nested url, correct response
curl -I https://6295310882fe9e2a5c53ad57--ethdotorg-corwin-test.netlify.app/en/staking/asadasd
HTTP/2 404

On existing paths, it is first returning a 404 but then it fetches the correct content.

=====

I would suggest turning off the flag generateMatchPathRewrites in our two redirect packages.

• https://www.gatsbyjs.com/plugins/gatsby-plugin-netlify/
• https://www.gatsbyjs.com/plugins/gatsby-plugin-gatsby-cloud/

That will avoid the rule gatsby-plugin-intl is writing for us, ending up in these files.
More context: that intl plugin is writing some matchPaths for each lang we have https://github.com/wiziple/gatsby-plugin-intl/blob/master/src/gatsby-node.js#L102

[samajammin]

@pettinarip will the recent change to our intl plugin #7022 change any of this?

[pettinarip]

@pettinarip will the recent change to our intl plugin #7022 change any of this?

I doubt it. The plugin is not touching many of these things. I mean, we are still doing the same as before in terms of redirects and 404s.

But I can take a look at this. I think it is related to the nested routes problem #6488

[pettinarip]

@corwintines closing this in favor of #7137