Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Event tracking guideline #6630

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Create Event tracking guideline #6630

merged 8 commits into from
Jul 15, 2022

Conversation

konopkja
Copy link
Contributor

@konopkja konopkja commented Jun 10, 2022

Event tracking guideline

Description

For developers to see how to structure event tracking and what to measure when creating/redesigning a page.

Related Issue

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 10, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 13m

Performance

Lighthouse report

Metric Score
Performance 🔶 19
Accessibility 💚 91
Best Practices 💚 100
SEO 💚 92

🔗 View full report


Please consider the visual position on the page, when deciding on which events should be grouped together (under the same category). Ideally, all events related to one feature should be grouped together under the same category only if there is also a single position on the page where the event can be triggered. If in doubt, always use different category when a feature is repeated on the page.

Example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: let's add a code example e.g. onClick event handler to demonstrate the util function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samajammin added a quick example here, is this what you were looking for?

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I renamed this to be a markdown file. Will review today.


1. Category (other events may share the same category if one feature has several actions)
2. Action
3. Label (optional)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matomo uses "name" which I think we should stick with: https://matomo.org/faq/reports/implement-event-tracking-with-matomo/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 9ddd7ad

@minimalsm minimalsm marked this pull request as ready for review July 15, 2022 10:45
docs/event-tracking.md Outdated Show resolved Hide resolved
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-) Nice work @konopkja

@minimalsm minimalsm merged commit 04e29ea into dev Jul 15, 2022
@minimalsm minimalsm deleted the konopkja-patch-1 branch July 15, 2022 11:04
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jul 15, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:

Head on over to GitPOAP.io and connect your GitHub account to mint!

@corwintines corwintines mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants