-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Event tracking guideline #6630
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m PerformanceLighthouse report
|
|
||
Please consider the visual position on the page, when deciding on which events should be grouped together (under the same category). Ideally, all events related to one feature should be grouped together under the same category only if there is also a single position on the page where the event can be triggered. If in doubt, always use different category when a feature is repeated on the page. | ||
|
||
Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: let's add a code example e.g. onClick event handler to demonstrate the util function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samajammin added a quick example here, is this what you were looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I renamed this to be a markdown file. Will review today.
docs/event-tracking.md
Outdated
|
||
1. Category (other events may share the same category if one feature has several actions) | ||
2. Action | ||
3. Label (optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matomo uses "name" which I think we should stick with: https://matomo.org/faq/reports/implement-event-tracking-with-matomo/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: 9ddd7ad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-) Nice work @konopkja
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
Event tracking guideline
Description
For developers to see how to structure event tracking and what to measure when creating/redesigning a page.
Related Issue