Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts migration(src/pages): Migrated assigned files #6829

Merged
merged 21 commits into from
Jul 16, 2022
Merged

Ts migration(src/pages): Migrated assigned files #6829

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d07548e
Feat(pages/404): Migrated 404.js => 404.tsx
M-Ivan Jun 26, 2022
564cb30
Fix(pages/404): Removed unnecessary round branckets string on 404 page
M-Ivan Jun 26, 2022
7e48a05
Feat(pages/404): Created interface for props and solved type errors
M-Ivan Jun 26, 2022
b7b59a1
Feat(pages/bug-bounty): Created interfaces for the page and improved …
M-Ivan Jun 26, 2022
f8dd080
Feat(pages/community): Community.js => Community.tsx
M-Ivan Jun 26, 2022
a0929e9
Feat(pages/community): Created interfaces for the community hub page
M-Ivan Jun 26, 2022
8c8d376
Fix(git): Merged branch 'dev' into base and solved conflicts
M-Ivan Jul 9, 2022
f8de08a
Fix(bug-bounty): Fixed the declaration of page props and the sort met…
M-Ivan Jul 9, 2022
06bfd9c
Fix(404): Fixed props definition
M-Ivan Jul 9, 2022
2cd06cd
Fix(assets): Fixed the props definition to use PageProps
M-Ivan Jul 9, 2022
556ece2
Fix(assets): Fixed props definition and removed unnecessary GetImage …
M-Ivan Jul 9, 2022
ab44844
Fix(community): Fixed props definition, array type declaration and re…
M-Ivan Jul 9, 2022
9c23674
Fix(bug-bounty): Removed unnecessary export statements
M-Ivan Jul 9, 2022
71c5447
Fix(404): Added extra space
M-Ivan Jul 10, 2022
f790f8b
Merge branch 'dev' into review-ivan2
pettinarip Jul 14, 2022
a7c1f76
revert changes on md files
pettinarip Jul 14, 2022
9ac4c16
simplify typing in assetdownload component
pettinarip Jul 14, 2022
aec7503
minor fixes on types
pettinarip Jul 15, 2022
e6a7b4e
Merge branch 'dev' into review-ivan2
pettinarip Jul 15, 2022
ecf33ad
call getImage on header image
pettinarip Jul 15, 2022
596c351
Merge branch 'dev' into review-ivan2
pettinarip Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AssetDownload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface IPropsWithSVG extends IPropsBase {
}
interface IPropsWithImage extends IPropsBase {
svg?: never
image: string
image: Record<string, unknown>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pettinarip since this prop is supposed to receive the GatsbyImageData object i changed this type to match any object. It was set to string before and it was a pain to make it work when passing a Gatsby auto-generated type (from the Queries namespace).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! as commented in the other comment, we will leave it as any for now. Once we have better types from gatsby we will refactor and fix all the images types 👍🏼

}

export type IProps = IPropsWithImage | IPropsWithSVG
Expand Down
135 changes: 77 additions & 58 deletions src/content/developers/docs/smart-contracts/testing/index.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/content/translations/de/developers/docs/smart-contracts/testing/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ incomplete: true

## Testtools und Bibliotheken {#testing-tools-and-libraries}

**Waffle – **_Ein Framework für fortgeschrittene Smart-Contract-Entwicklungen und Tests (basierend auf ethers.js)_**
**Waffle – **_Ein Framework für fortgeschrittene Smart-Contract-Entwicklungen und Tests (basierend auf ethers.js)_\*\*

- [getwaffle.io](https://getwaffle.io/)
- [GitHub](https://github.com/EthWorks/Waffle)
Expand Down
5 changes: 3 additions & 2 deletions src/pages/404.js → src/pages/404.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,20 @@ import Link from "../components/Link"
import Translation from "../components/Translation"

import { Page, Content } from "../components/SharedStyledComponents"
import { PageProps } from "gatsby"

const StyledPage = styled(Page)`
margin-top: 4rem;
`

const NotFoundPage = () => (
const NotFoundPage = (props: PageProps) => (
<StyledPage>
<Content>
<h1>
<Translation id="we-couldnt-find-that-page" />
</h1>
<p>
<Translation id="try-using-search" />{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need that extra space

<Translation id="try-using-search" />
<Link to="/">
<Translation id="return-home" />
</Link>
Expand Down
Loading