refactor: migrate listed components to typescript #6909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didoshotev
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 12m |
pettinarip
requested changes
Jul 12, 2022
| isReverse = false, | ||
| children, | ||
| className, | ||
| }) => { | ||
| const { buttons, title, header, subtitle, image, alt } = content |
There was a problem hiding this comment.
For now, we could add the content interface in this file with this structure. Could be something like:
interface IButton {
path: string
pathId: string
}
interface IContent {
buttons?: Array<IButton>
title: string
header: string
subtitle: string
image: string
alt: string
}
|
@pettinarip I have made the requested changes and pulled the new changes from dev. Let me know if something else needs to be added for this PR. |
pettinarip
approved these changes
Jul 16, 2022
There was a problem hiding this comment.
Thanks @didoshotev. I've pushed a few minor things but overall it looks great! thanks for applying the suggestions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate listed components:
src/components/PageHero.js
src/components/SkipLink.js
In PageHero content prop, I have set it to any, since I don't see any TS interface for this type of data. This can be changed once we have defined interface.
Please let me know, if you want to separate
SkipLinkAnchorinto different file, as there are 2 components in the same file (SkipLink) currently.Related Issue
Refs: #6392