Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect nested routes to default lang #7135

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Redirect nested routes to default lang #7135

merged 3 commits into from
Jul 21, 2022

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Jul 19, 2022

  1. For each defaultLang page we create, lets also create a redirect from the root paths. E.g. for /en/nft create a redirect from /nft to /en/nft.
  2. Cleanup the redirects.json file. Leave only the custom redirects. The rest are dynamically generated by the previous logic.

Fixes: #6488 #7097

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 19, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 32m

@pettinarip pettinarip force-pushed the fix-nested-redirects branch from ed3ec62 to 7672842 Compare July 19, 2022 15:37
@pettinarip pettinarip marked this pull request as ready for review July 19, 2022 20:33
@pettinarip pettinarip mentioned this pull request Jul 20, 2022
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me! Nice job.

Screen Shot 2022-07-20 at 4 32 58 PM

Sent a message, but noticed this in the console. Could have always been there and im just noticing it now as well.

@pettinarip
Copy link
Member Author

@corwintines Thanks for the review and nice catch! I'll try to fix them before merging it.

@pettinarip pettinarip merged commit 47df8a4 into dev Jul 21, 2022
@pettinarip pettinarip deleted the fix-nested-redirects branch July 21, 2022 16:25
@corwintines corwintines mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep URLs not forwarding to default language
2 participants