chore: convert statLoadingMessage #8199
Conversation
therealharpaljadeja
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Hey @therealharpaljadeja! Nice work. One tiny detail from me and then I think this is good to go! 😄
@pettinarip noting that the StatErrorMessage component needs to be migrated first before this is merged, as it is dependent on a Styled component (IndicatorSpan) originally imported from this component.
| export const IndicatorSpan = styled.span<IProps>` | ||
| ${typography} | ||
| ` | ||
| export interface IProps {} |
There was a problem hiding this comment.
This interface needs to be expanded to include a Chakra props type so that you can pass in Chakra props at the parent level. (i.e. The Stat component in what-is-ethereum page currently throws a type error)
| export interface IProps {} | |
| export interface IProps extends TextProps {} |
|
Good point @TylerAPfledderer ✌🏼 I'll quickly add those things in here. |
There was a problem hiding this comment.
lgtm! thanks @therealharpaljadeja
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @therealharpaljadeja for code |
|
I've put up a pull request to add @therealharpaljadeja! 🎉 |
Description
Convert the StatLoadingMessage component to Chakra
Related Issue
Epic: #6374