React i18next #8406
React i18next #8406
Conversation
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
…fy our browser & ssr gatsby files
| } | ||
|
|
||
| return <Layout {...props}>{element}</Layout> | ||
| } |
There was a problem hiding this comment.
gatsby-browser & gatsby-ssr content was replaced by the usage of gatsby-plugin-layout.
| dangerouslySetInnerHTML={{ | ||
| __html: t("page-staking-hierarchy-solo-p1"), | ||
| }} | ||
| /> |
There was a problem hiding this comment.
This is a temporary implementation. In the next iteration we are planning in using the following approach: https://react.i18next.com/latest/trans-component#using-with-react-components where we will also need to modify our translation files.
src/pages-conditional/wallets.tsx
Outdated
| @@ -494,7 +478,16 @@ export const listImage = graphql` | |||
| ` | |||
|
|
|||
| export const query = graphql` | |||
| query WalletsPage { | |||
| query WalletsPage($language: String!) { | |||
| locales: allLocale(filter: { language: { eq: $language } }) { | |||
There was a problem hiding this comment.
On each page, we need to fetch the selected language strings.
|
When reviewing I noticed a bug with our link styling for links embedded as HTML in JSON files - #8547. |
|
Noticed our intl tutorials aren't loading properly |
Uhmm good catch @wackerow! I'm looking into it now. Thanks |
|
Noticed this on the other PR, but it's also happening here. If a string is not available in a language, I would expect it to fall back to English strings. This is what happens in this PR:
|
Good catch @minimalsm I thought I had that covered! will take a look, thanks! |
i18n lib change - use htmr to parse html inside json files #8585
There was a problem hiding this comment.
LGTM, nice one
Noting, we need to update /docs/best-practices.md
|
@corwintines I'll create a new PR with those updates 👍🏼 thanks for pointing that out. |
Description
Implement
react-i18nextby using the next plugin https://github.com/microapps/gatsby-plugin-react-i18nextKnown issues:
Related Issue
#8345