Added p2p.org Ethereum staking as a service #9329
Conversation
…roduct, added logic to display grayscale-colored brands in staking products (in case brand have no color in their design), saas services icons tweaked to be able to display non-square icons
rgb2hsl
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
…ndition so hue can be 0
|
I don't know if it's okay or not, but Labeler/label job is faild and it says:
|
# Conflicts: # src/components/Staking/StakingProductsCardGrid.tsx
|
Conflicts resolved |
https://build-bbb7e349-eba8-46f5-a238-6d7044841ecc.gatsbyjs.io/ Looks and functions as expected |
|
@wackerow do you have a moment to review this? |
There was a problem hiding this comment.
Hey @rgb2hsl! Thanks for the issue and PR, apologies for delays here, appreciate you bearing with us... This overall looks good and don't see any reason not to list P2P.org, but have a couple questions/comments.
Curious if you could help me understand how P2P takes a cut of the rewards, since it was mentioned in the issue that the withdrawal credentials are linked directly to the users desired withdrawal address. It looks like you folks do the key generation, correct?... is the smart contract addressed used here for withdrawal credentials, or is it the users address?
Are users required to sign-up for an account?
No, if a user works with our Ethereum Staking Service, they do not need to go through KYC because their assets do not get to our account and are sent directly to the Ethereum network.
Also curious about this response. When going through the flow on the site I encountered a required email field for authorization:
The question here is addressing the "permissionless" question... is there any ability for P2P to deny users who deposit ETH?
Lastly, I would kindly request that we remove the design changes that were implemented in this PR. This has resulted in bugs with the other products that are listed, and these design changes are out-of-scope for a product listing.
If we want to introduce design changes, I would ask that a separate issue be raised so we can get feedback from others including our designers. That being said, I definitely understand that the "hue" approach here doesn't work well with a black product color.
If possible, would request we select a hue for now to allow us to get this PR in, and then address anything design related separately to help keep things organized.
| "svgPath": "p2p-glyph.svg", | ||
| "hue": null, | ||
| "grayscaleLum": 0, | ||
| "launchDate": "2020-12-15", |
There was a problem hiding this comment.
If users are using new smart contracts (even if audited) that have only been used since December 2022, I would use this date instead. If we're using smart contracts from genesis then the earlier date would make sense, but it doesn't sound like that's the case (please correct me if I'm wrong here).
This is meant to indicate a level of "battle testing." If the first deposit to the smart contracts being used currently was December 2022, I would use this date to not deceive users.
| "launchDate": "2020-12-15", | |
| "launchDate": "2022-11-01", |
There was a problem hiding this comment.
We'are about to update our depositor smart contract. I'll put the updated info here of course. But the question is — am I get it right that every smart contract changes will lead to the "reset" of the launchDate and it always supposed to be the date of starting using all system (dapp + smart contracts + all other middlewares) together within it's certain versions?
|
Going to close this out as it seems to be abandoned at the requested changes here. @rgb2hsl if this isn't abandoned, feel free to open another PR with the requested changes addressed. |
github-actions
bot
added
the
abandoned
|
@corwintines Hi! I've opened another PR with updated info about P2P: #11279 Please, mind taking a look on it. Thanks! |
P2P added to /staking/saas/ website's article as saas product. Some minor improvements been made to the page to extend the branding possibilities: brands with wide logos and grayscale background now supported.
Description
/staking/saas/page in case of brands, that doesn't have no color in their designs;/staking/saas/styled to be able to display non-square icons;Related Issue
Resolves #9326