Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y/refactor meetup list #9576

Merged
merged 2 commits into from
May 30, 2023
Merged

A11y/refactor meetup list #9576

merged 2 commits into from
May 30, 2023

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Feb 24, 2023 •
edited
Loading

Description

Refactors the MeetupList component for improved accessibility.

  • Provides added clarification for screen reader that the results update as the user types into the input field
  • If there are no results based on input, a live region fires to readout the "no results" content for the screen reader.
  • When the user navigates into a list of results, the screen reader provides a specific identification to the list for cognitive clarity while reading out the current number of results.
  • Renders list components.
  • Applies useColorModeValue hook for box shadow renderings.

Related Issue

Closes #8580

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 24, 2023 •
edited
Loading

✅ ethereum-org-website-dev deploy preview ready

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies documentation 📖 event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Apr 14, 2023
@TylerAPfledderer TylerAPfledderer force-pushed the a11y/refactor-meetup-list branch from 97faab2 to 7ae40db Compare April 14, 2023 00:28
@corwintines corwintines merged commit 99269c6 into ethereum:dev May 30, 2023
@TylerAPfledderer TylerAPfledderer deleted the a11y/refactor-meetup-list branch May 30, 2023 23:39
This was referenced May 31, 2023
Merged
Merged
Merged
@corwintines corwintines mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

@djrtwo djrtwo Awaiting requested review from djrtwo

@JustinDrake JustinDrake Awaiting requested review from JustinDrake

@asanso asanso Awaiting requested review from asanso

@fredriksvantes fredriksvantes Awaiting requested review from fredriksvantes

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y Refactor: MeetupList Component
2 participants
@TylerAPfledderer @corwintines