-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce heterogeneous vocabulary for Consensus layer/Beacon Chain #9589
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
Hey @SebastianSupreme, thanks for dropping this! To my knowledge, despite using the terms "consensus" and "execution" to refer to these layers and client types, we do still use "Beacon Chain" in the consensus specs. |
btw there was some discussion around this at merge-time. It was inconclusive, but the arguments are at least laid out in the issue description: #7828 |
Considering that the page about the Beacon Chain speaks of it in past tense, indicating that it doesn't exist anymore, we should be consistent with this and remove the name from pages which are meant to explain Ethereum in simple terms in order to avoid any confusion for new readers (e.g. the staking pages). |
@corwintines Can we merge this now? According to the linked discussion, most people are in favor of this change. |
I personally disagree with removing the Beacon Chain terminology, but I do agree that the wording presented on the I'd be more in favor of correcting the tense surrounding this copy than to remove the name "Beacon Chain", which the page has always been named, in included in the URL, and is still used in the specs. |
I agree with @wackerow. @SebastianSupreme would you be interested in updating this instead? |
So, it seems like I was wrong and the Beacon Chain does still exist as Ethereum's consensus layer but has been modified compared to the pre-merge Beacon Chain. But even so, it still keeps its name after those updates and after being given the purpose to be Ethereum's consensus layer. I'd be happy to rewrite the Beacon Chain page accordingly and remove the confusion that is caused by the past tense wording. |
yea i agree - I feel like the window for updating terms has kind of closed now being so far post-merge. BC has persisted and is pretty well embedded now. No need to purge the term from the site generally. That said, I still prefer @SebastianSupreme 's updates using @SebastianSupreme if you want to try to clarify the page then please go ahead and raise a PR, happy to go along with the consensus here. |
@jmcook1186 suggested using consensus layer instead of Beacon Chain whenever it is mentioned elsewhere and those changes are already included in this PR here. |
@SebastianSupreme could you fix conflicts here, ill pull in after :) Thanks! |
@corwintines should be good to go now |
@jmcook1186 @wackerow please review and confirm we're happy here 😀 (either or, don't need you both to review, i don't think...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just left one small suggestion but not critical
cc: @corwintines
src/content/developers/docs/consensus-mechanisms/pos/attack-and-defense/index.md
Outdated
Show resolved
Hide resolved
…d-defense/index.md Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Repurposed extension of #10356