Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce heterogeneous vocabulary for Consensus layer/Beacon Chain #9589

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

SebastianSupreme
Copy link
Contributor

@SebastianSupreme SebastianSupreme commented Feb 28, 2023

Repurposed extension of #10356

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 28, 2023

✅ ethereum-org-website-dev deploy preview ready

@jmcook1186 jmcook1186 added the needs technical content review 🧑‍🏫 Needs a technical content review before merging label Feb 28, 2023
@wackerow
Copy link
Member

wackerow commented Mar 7, 2023

Hey @SebastianSupreme, thanks for dropping this! To my knowledge, despite using the terms "consensus" and "execution" to refer to these layers and client types, we do still use "Beacon Chain" in the consensus specs.
@djrtwo Any thoughts here? Is this a term the devs are trying to deprecate entirely?

@jmcook1186
Copy link
Contributor

btw there was some discussion around this at merge-time. It was inconclusive, but the arguments are at least laid out in the issue description: #7828

@SebastianSupreme
Copy link
Contributor Author

Considering that the page about the Beacon Chain speaks of it in past tense, indicating that it doesn't exist anymore, we should be consistent with this and remove the name from pages which are meant to explain Ethereum in simple terms in order to avoid any confusion for new readers (e.g. the staking pages).
Pages which do include a more technical terminology may continue to refer to the Beacon Chain for now because I'm aware that the consensus specs contain remains of Beacon Chain terminology as well.

@SebastianSupreme
Copy link
Contributor Author

@corwintines Can we merge this now? According to the linked discussion, most people are in favor of this change.

@wackerow
Copy link
Member

I personally disagree with removing the Beacon Chain terminology, but I do agree that the wording presented on the /roadmap/beacon-chain/ pages is poor. To my knowledge, the intent of rewording the "tense" on that page after upgrades were checked off was not to imply that the Beacon Chain no longer existed. The intro appears to try to tell a story of when the Beacon Chain started, but it definitely gives a tone that it no longer exists.

I'd be more in favor of correcting the tense surrounding this copy than to remove the name "Beacon Chain", which the page has always been named, in included in the URL, and is still used in the specs.

@corwintines
Copy link
Member

I agree with @wackerow. @SebastianSupreme would you be interested in updating this instead?

@SebastianSupreme
Copy link
Contributor Author

SebastianSupreme commented May 31, 2023

So, it seems like I was wrong and the Beacon Chain does still exist as Ethereum's consensus layer but has been modified compared to the pre-merge Beacon Chain. But even so, it still keeps its name after those updates and after being given the purpose to be Ethereum's consensus layer.

I'd be happy to rewrite the Beacon Chain page accordingly and remove the confusion that is caused by the past tense wording.

@jmcook1186
Copy link
Contributor

yea i agree - I feel like the window for updating terms has kind of closed now being so far post-merge. BC has persisted and is pretty well embedded now. No need to purge the term from the site generally. That said, I still prefer @SebastianSupreme 's updates using consensus layer in most cases tbh.

@SebastianSupreme if you want to try to clarify the page then please go ahead and raise a PR, happy to go along with the consensus here.

@SebastianSupreme SebastianSupreme changed the title Remove mention of deprecated Beacon Chain Embrace the Beacon Chain 🤝 May 31, 2023
@SebastianSupreme SebastianSupreme changed the title Embrace the Beacon Chain 🤝 Remove mention of deprecated Beacon Chain May 31, 2023
@SebastianSupreme
Copy link
Contributor Author

SebastianSupreme commented May 31, 2023

@jmcook1186 suggested using consensus layer instead of Beacon Chain whenever it is mentioned elsewhere and those changes are already included in this PR here.
@corwintines @wackerow What do you guys think?
If everyone agrees on this we could just use this PR for that.

@corwintines
Copy link
Member

@SebastianSupreme could you fix conflicts here, ill pull in after :) Thanks!

@SebastianSupreme SebastianSupreme requested a review from nhsz as a code owner June 12, 2023 14:06
@SebastianSupreme
Copy link
Contributor Author

@corwintines should be good to go now

@minimalsm
Copy link
Contributor

minimalsm commented Jun 12, 2023

@jmcook1186 @wackerow please review and confirm we're happy here 😀 (either or, don't need you both to review, i don't think...)

@SebastianSupreme SebastianSupreme changed the title Remove mention of deprecated Beacon Chain Introduce heterogeneous vocabulary for Consensus layer/Beacon Chain Jun 12, 2023
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just left one small suggestion but not critical
cc: @corwintines

…d-defense/index.md

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@corwintines corwintines merged commit 44b2645 into ethereum:dev Jun 13, 2023
This was referenced Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs technical content review 🧑‍🏫 Needs a technical content review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants