[A11y] refactor(ProductList): improve structure and accessibility #9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
TylerAPfledderer
requested review from
djrtwo,
asanso and
fredriksvantes
as code owners
github-actions
bot
added
content 🖋️
TylerAPfledderer
force-pushed
the
refactor/product-list-a11y-and-layout
branch
2 times, most recently
from
d04dd48 to
6377bc0
Compare
corwintines
reviewed
Jul 3, 2023
src/components/ProductList.tsx
Outdated
| @@ -22,10 +31,13 @@ export interface IProps { | |||
| const ProductList: React.FC<IProps> = ({ content, category }) => { | |||
| const shadow = useColorModeValue("tableBox.light", "tableBox.dark") | |||
|
|
|||
| const ariaLabelledby = "cat-name" | |||
There was a problem hiding this comment.
I just had a question abut this label. Im a little confused what "cat-name" is. Should the be "category-name", or should we actually be passing the category prop instead?
There was a problem hiding this comment.
This is just an id because it is being used in two places (lines 40 and 51) for the aria-labelledby feature.
I can be clearer here in using a more verbose id, along with uppercase variable naming to denote this as a const variable 😁
There was a problem hiding this comment.
Sure! I pushed those changes up. This should be good to go now :)
corwintines
approved these changes
Jul 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves accessibility navigating the
ProductListcomponent with a screen reader.ListandListItemcomponents.aria-labelledbyto ensure the user knows what the list should they skip the headingSecondary addition to the PR
This PR also updates the layout to provide more consistency with spacing.
cc @nloureiro for approval on this
Related Issue
Closes #8878