Fix slow import #1061
Merged
Fix slow import #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
reviewed
Apr 27, 2018
|
|
||
| # defines a number of opened files by db instance | ||
| # this number has significant impact on read amplification | ||
| # on the other hand it can force exceeding of user's limit, OS usually set it to 1024 |
There was a problem hiding this comment.
OS usually set it to 1024
+ "for all applications
|
|
||
| public static final DbSettings DEFAULT = new DbSettings(); | ||
|
|
||
| int maxOpenFiles = 32; |
There was a problem hiding this comment.
Maybe add 2 more vars as statics above and assign here from them?
Don't like a way magic constants are passed.
There was a problem hiding this comment.
Agree. Don't like them either :)
|
@zilm13 ready to be merged after the review |
|
@mkalinin to be clear, LevelDB has |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.