Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] State transition #1177

Merged
merged 23 commits into from
Sep 14, 2018
Merged

[WIP] State transition #1177

merged 23 commits into from
Sep 14, 2018

Conversation

mkalinin
Copy link
Contributor

Yet not ready for merge, as always :)

ToDo:

  • tests
  • javadoc

Resolves #1143

@mkalinin mkalinin added this to the Beacon milestone Sep 12, 2018
@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.1%) to 56.159% when pulling 7c4449c on sharding/state-transition into 2e07679 on research/sharding.

}

@Override
public synchronized Validator get(Integer index) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it enough for this structure to have only get by index №?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be not in the future, but for now let's keep it simple

@@ -0,0 +1,11 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add smth with 0's omit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without 0x prefix?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean odd hex symbols for example. To test it's passing through hex helper you've added correctly

@mkalinin
Copy link
Contributor Author

Looks like it is ready for merge. @zilm13 please, approve.

Copy link
Collaborator

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@mkalinin mkalinin merged commit 89e417c into research/sharding Sep 14, 2018
@mkalinin mkalinin deleted the sharding/state-transition branch December 26, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants