optimization p2p #1242
Open
optimization p2p #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashatyrev
requested changes
Dec 4, 2018
| stateChanged(oldState, newState); | ||
| if (newState == State.Active) { | ||
| stateChanged(oldState, newState); | ||
| } |
There was a problem hiding this comment.
I don't understand why this change doesn't break anything. Why stateChanged() should be called only on Active?
There was a problem hiding this comment.
firstly, when the oldest node challenge With the new node,and the oldest node win,we should update the oldest timestap,or else, the node will be get when a new node was added and the bucket was full at next time.
secondly, as the origin code did ,when a node state was change ,the method stateChanged was called every time ,and the method is mainly to establish tcp connect with the peer node ,did it need ?I think when the node in active status, they should start a connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.