Constantinople #1246
Merged
Constantinople #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts-only solution
… implemented using ContractDetails
mkalinin
suggested changes
Dec 26, 2018
| Repository originalRepo = track; | ||
| // removes address in main track copy if the same address already exists | ||
| // TCK test case only - normally this is near-impossible situation in the real network | ||
| if (cacheTrack.hasContractDetails(newContractAddress)) { |
There was a problem hiding this comment.
Doesn't this call always return true?
There was a problem hiding this comment.
And could you please share more details about the case which this workaround is made for?
There was a problem hiding this comment.
Doesn't this call always return true?
Looks like you are right from the implementation.
But as we have such interface method for checking and as implementations could change in future, I'd keep this.
mkalinin
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to schedule Constantinople fork on MainNet:
Review me!