Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

org.ethereum.net.rlpx.discover.NodeManager::setBootNodes should be … #1262

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

netwalker2000
Copy link

public and not package-private. Without setting boot nodes, the object is very difficult to use outside of the package.

…`public` and not package-private. Without setting boot nodes, the object is very difficult to use outside of the package.
@netwalker2000
Copy link
Author

from issue #1171

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 57.027% when pulling ca12ef2 on netwalker2000:develop into 580362c on ethereum:develop.

@mkalinin mkalinin merged commit 08e89f1 into ethereum:develop Feb 14, 2019
@mkalinin
Copy link
Contributor

Thanks 👍

@netwalker2000
Copy link
Author

I'm hornored :)

derekzuk pushed a commit to derekzuk/ethereumj that referenced this pull request Apr 3, 2019
…`public` and not package-private. Without setting boot nodes, the object is very difficult to use outside of the package. (ethereum#1262)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants