Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmtester: Drop CLI11 dependency #221

Merged
merged 6 commits into from
Mar 25, 2019
Merged

vmtester: Drop CLI11 dependency #221

merged 6 commits into from
Mar 25, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Mar 16, 2019

Closes #220.

@chfast chfast requested review from axic and gumb0 March 17, 2019 22:11
axic
axic approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the new CLI parsing code, but the rest look ok.

gumb0
gumb0 reviewed Mar 19, 2019
View reviewed changes
test/vmtester/vmtester.cpp Outdated Show resolved Hide resolved
@chfast chfast force-pushed the vmtester branch 2 times, most recently from 743e369 to d5f9eee Compare March 25, 2019 10:15
@chfast chfast requested review from axic and gumb0 March 25, 2019 10:20
@chfast chfast merged commit c1ee3c0 into master Mar 25, 2019
@chfast chfast deleted the vmtester branch March 25, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @axic @gumb0